Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Queriers from having a single error output parameter #43

Open
jonbodner opened this issue Nov 13, 2019 · 0 comments
Open

Prevent Queriers from having a single error output parameter #43

jonbodner opened this issue Nov 13, 2019 · 0 comments
Assignees

Comments

@jonbodner
Copy link
Owner

Right now, you can define a querier with 0, 1, or 2 output parameters. An error is only returned if there are two output parameters. If you use 1 output parameter of type error, the error is swallowed. Also, it doesn't make any sense to have a querier that doesn't query; you should return a value.

The fix is to make sure that if there is only a single parameter being returned it cannot be of type error.

@jonbodner jonbodner self-assigned this Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant