Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crashes when drawing resonance #1429

Open
kayaulai opened this issue Jun 13, 2023 · 5 comments
Open

Crashes when drawing resonance #1429

kayaulai opened this issue Jun 13, 2023 · 5 comments
Assignees
@kayaulai
Labels
bug Something isn't working
Projects
Core

Comments

@kayaulai
Copy link
Collaborator

kayaulai commented Jun 13, 2023 •
edited by johnwdubois
Loading

The first error appears when linking 'her' and 'me' here:
image

also when starting a new chain on the highlighted 'do':

image

and also linking up the 'and's:

image

To reproduce
Maybe after merging 2 resonance chains together?

############################################################################################
ERROR in
action number 1
of Draw Event
for object obj_control:

ds_map_find_value argument 1 incorrect type (undefined) expecting a Number (YYGI32)
at gml_Script_scr_setCliqueAutoTags
############################################################################################
gml_Script_scr_setCliqueAutoTags (line -1)
gml_Script_scr_mergeCliques
gml_Script_scr_newLink
gml_Script_scr_tokenClicked
gml_Script_scr_drawLineEntryList
gml_Script_scr_drawLine2ElectricBoogaloo
gml_Object_obj_control_Draw_0

A different one, while drawing chunk around 'in the casino':

############################################################################################
ERROR in
action number 1
of Draw Event
for object obj_control:

ds_map_find_value argument 1 incorrect type (undefined) expecting a Number (YYGI32)
at gml_Script_scr_mergeCliques
############################################################################################
gml_Script_scr_mergeCliques (line -1)
gml_Script_scr_newLink
gml_Script_scr_createChunk
gml_Script_scr_mouseRect
gml_Object_obj_control_Draw_0

image
@kayaulai kayaulai self-assigned this Jun 13, 2023
@kayaulai kayaulai changed the title Crash when drawing resonance Crashes when drawing resonance Jun 13, 2023
@johnwdubois johnwdubois added the bug Something isn't working label Jun 13, 2023
@johnwdubois johnwdubois added this to To do in Core via automation Jun 13, 2023
@johnwdubois johnwdubois moved this from To do to In progress in Core Jun 13, 2023
@kayaulai
Copy link
Collaborator Author

And here's a third one:

############################################################################################
ERROR in
action number 1
of Draw Event
for object obj_control:

ds_map_find_value argument 1 incorrect type (undefined) expecting a Number (YYGI32)
at gml_Script_scr_cliqueCheckChain
############################################################################################
gml_Script_scr_cliqueCheckChain (line -1)
gml_Script_scr_refreshClique
gml_Script_scr_newLink
gml_Script_scr_createChunk
gml_Script_scr_mouseRect
gml_Object_obj_control_Draw_0

image

@johnwdubois johnwdubois moved this from In progress to To do in Core Jun 19, 2023
@kayaulai
Copy link
Collaborator Author

kayaulai commented Jul 30, 2023 •
edited
Loading

Here's a reproducible example (see screenshot for the action taken).

diamond resonance.zip

############################################################################################
ERROR in
action number 1
of Draw Event
for object obj_control:

ds_map_find_value argument 1 incorrect type (undefined) expecting a Number (YYGI32)
at gml_Script_scr_setCliqueAutoTags
############################################################################################
gml_Script_scr_setCliqueAutoTags (line -1)
gml_Script_scr_mergeCliques
gml_Script_scr_newLink
gml_Script_scr_tokenClicked
gml_Script_scr_drawLineEntryList
gml_Script_scr_drawLine2ElectricBoogaloo
gml_Object_obj_control_Draw_0

image

@kayaulai
Copy link
Collaborator Author

kayaulai commented Jul 30, 2023 •
edited
Loading

And a new one! This time reproducible. The search term is 名.

image

diamond resonance fulltext.zip

############################################################################################
ERROR in
action number 1
of Draw Event
for object obj_control:

ds_map_find_value argument 1 incorrect type (undefined) expecting a Number (YYGI32)
at gml_Script_scr_refreshChainOrderMap
############################################################################################
gml_Script_scr_refreshChainOrderMap (line -1)
gml_Script_scr_newLink
gml_Script_scr_tokenClicked
gml_Script_scr_drawLineEntryList
gml_Script_scr_drawLine2ElectricBoogaloo
gml_Object_obj_control_Draw_0

@kayaulai
Copy link
Collaborator Author

And another new one, when making side links:

############################################################################################
ERROR in
action number 1
of Draw Event
for object obj_dialogueBox:

ds_map_find_value argument 1 incorrect type (undefined) expecting a Number (YYGI32)
at gml_Script_scr_refreshChainOrderMap
############################################################################################
gml_Script_scr_refreshChainOrderMap (line -1)
gml_Script_scr_newLink
gml_Script_scr_dialogueConfirm
gml_Object_obj_dialogueBox_Draw_0

@johnwdubois
Copy link
Owner

Ryan says:
I've added a reproducible example of the resonance crash to GitHub.....
I hope this bug can be prioritised in the future development of Rezonator, as it's extremely common when dealing with resonance.
JWD: Yes, let's prioritize this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kayaulai kayaulai

Labels
bug Something isn't working
Projects
Core
Status: To do
Core
  
To do
Milestone
No milestone
Development

No branches or pull requests
2 participants
@johnwdubois @kayaulai