Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MySQL provider doesn't work with an empty password #48

Open
tofulm opened this issue Dec 11, 2017 · 4 comments
Open

MySQL provider doesn't work with an empty password #48

tofulm opened this issue Dec 11, 2017 · 4 comments
Labels

Comments

@tofulm
Copy link

tofulm commented Dec 11, 2017

Hello,
My default config of mysql has an empty password.

the prompt ask the password but it's not possible to write it down.

With Neovim 2.3

@joereynolds
Copy link
Owner

Hey,

Thanks for the report! I'll take a look

@joereynolds
Copy link
Owner

joereynolds commented Dec 11, 2017

  • Allow command to work with and without password
  • Fix postBufferFormat behaviour
  • Fix 'e' on SQHResult buffer
  • Refactor getDatabaseName
  • Tests that check mysql works with and without a password (if one is not set)
  • Tests that check for Tables_in_ anywhere in the buffer, not necessarily the first line
  • Tests for postBufferFormat (buffers that show the password warnings, buffers with just a newline, and a normal buffer)

@joereynolds joereynolds mentioned this issue Dec 11, 2017
2 tasks
@joereynolds joereynolds changed the title pb with password empty MySQL provider doesn't work with an empty password Dec 12, 2017
@deeuu
Copy link

deeuu commented Nov 22, 2018

Hey,
I also ran into this issue (empty password doesn't work with MYSQL provider).

I think the fix is as easy replacing this with:

let l:password = '--password=' . a:password . ' '

I can send a PR, but I'm not sure about the items checked in your comment?

@joereynolds
Copy link
Owner

Hey @deeuu,

You're welcome to raise a PR, don't worry about the items in my comment, those are ongoing, though if you can add some tests around the area that'd be great :D

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants