You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Oct 10, 2024. It is now read-only.
According to the path configuration file, the client handles GET /navigations requests with the "basic" stack, and GET /modal/new
requests with the "modal" stack.
This commit modifies the modals#new action to redirect to navigations#show when the ?redirect query parameter is present.
This GET to GET redirect causes issues on the client, since at
request-time, the client thinks its handling a "modal" navigation,
but at response-time, the client is served a route that it'd handle
as a "basic"` navigation.
The resulting behavior is a bug through the following sequence:
present the "modal" stack by animating up from the bottom of the
screen
render an empty screen
dismiss the "modal" stack
pop the entirety of the "basic" stack
replace the root with the navigations#show response
Once the navigation completes, the old root screen is entirely
unavailable. There is no navigation "Back" button, gestures don't pop
off the stack, and pull to refresh re-requests the navigations#show
page.
According to the path configuration file, the client handles
GET /navigations
requests with the "basic" stack, andGET /modal/new
requests with the "modal" stack.
This commit modifies the
modals#new
action to redirect tonavigations#show
when the?redirect
query parameter is present.This
GET
toGET
redirect causes issues on the client, since atrequest-time, the client thinks its handling a "modal" navigation,
but at response-time, the client is served a route that it'd handle
as a "basic"` navigation.
The resulting behavior is a bug through the following sequence:
screen
navigations#show
responseOnce the navigation completes, the old root screen is entirely
unavailable. There is no navigation "Back" button, gestures don't pop
off the stack, and pull to refresh re-requests the
navigations#show
page.
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-02-09.at.19.15.22.mp4
The reproduction code is available at https://github.com/seanpdoyle/TurboNavigator/tree/redirect-get-modal-to-get-basic
The text was updated successfully, but these errors were encountered: