-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
convertHtmlToDelta does not create the exact delta that quill works with #3
Comments
by setting delta as content to quill and then returning the content fix joelcolucci#3 BREAKING CHANGE: This likely alters the result of any convertHtmlToDelta conversion. Depending of what people are doing with the delta this might break things.
Hi @Xiphe, Thanks for submitting this issue (and PR). I'll take a look at this shortly and will follow up! Thank you for your patience and work. - Joel |
@Xiphe I apologize for the delay. I'll be reviewing this, this week! |
I can confirm the input/output provided for convertHtmlToDelta . Input:
Resulting Output:
@Xiphe Can you provide the following for when you experience the issue in browser?
|
Latest Quill |
Hi @Xiphe , Can you send me the semvers for each? |
Hey @joelcolucci, in the meantime we stopped using this package since there seems to be a memory leak (which we did not debug properly, so I can not tell you where and why). Versions related to this issue:
From my side you can also just close this + #4 - It's up to you. |
Thanks @Xiphe . I appreciate the feedback and update. This month I am committing more time to this project. Are you able to share at what scale the memory leak occurred at? As in converting 1000, 10000, 100000 quills etc? Thank you again for your time. |
As in not converting at all but loading the module. But as I said, we have not digged any deeper. Could also be a not relate to this module and we interpreted s.th. wrong. Maybe @fgnass knows a little more here. |
+1 on the memory leak. Just figured that out after simply loading the module. node.js 10.10.0 |
@joelcolucci Is memory leak issue resolved now? I have to convert HTML to Delta on node server side. So i need this package to implement on node side |
Hey all. Just published version 0.3.3 which should resolve the memory leak from importing the module. See #10 for updates. |
Given I paste
<h2>Hello</h2><p>World</p>
into a quill instance running in a real browser.getContents
will returnwhile
convertHtmlToDelta
returnsThis cause problems with dirty-checks when the contents of quill are used in a
<form>
.Will submit a PR.
The text was updated successfully, but these errors were encountered: