Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: remove cached instance #1

Merged
merged 10 commits into from
Jun 23, 2021
Merged

Bugfix: remove cached instance #1

merged 10 commits into from
Jun 23, 2021

Conversation

Drarok
Copy link
Owner

@Drarok Drarok commented Jun 23, 2021

This fixes joelcolucci#22, at the cost of performance:

Before:

 FAIL  test/node-quill-converter.test.js
  node-quill-converter
    ✓ convertTextToDelta (77ms)
    ✓ convertHtmlToDelta (7ms)
    ✓ convertHtmlToDelta (3ms)
    ✓ GitHub Issue #2 (6ms)

After:

 PASS  test/node-quill-converter.test.js
  node-quill-converter
    ✓ convertTextToDelta (178ms)
    ✓ convertHtmlToDelta (108ms)
    ✓ convertHtmlToDelta (77ms)
    ✓ GitHub Issue #2 (76ms)
    ✓ GitHub Issue #22 (294ms)

dependabot bot and others added 10 commits April 5, 2020 08:38
@dependabot
chore(deps): bump acorn from 5.7.3 to 5.7.4
9c79b53 
Bumps [acorn](https://github.com/acornjs/acorn) from 5.7.3 to 5.7.4.
- [Release notes](https://github.com/acornjs/acorn/releases)
- [Commits](acornjs/acorn@5.7.3...5.7.4)

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot
chore(deps): bump y18n from 4.0.0 to 4.0.1
82d329b 
Bumps [y18n](https://github.com/yargs/y18n) from 4.0.0 to 4.0.1.
- [Release notes](https://github.com/yargs/y18n/releases)
- [Changelog](https://github.com/yargs/y18n/blob/master/CHANGELOG.md)
- [Commits](https://github.com/yargs/y18n/commits)

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot
chore(deps): bump lodash from 4.17.15 to 4.17.21
7f1403a 
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.21.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](lodash/lodash@4.17.15...4.17.21)

Signed-off-by: dependabot[bot] <[email protected]>
@Drarok
Merge remote-tracking branch 'origin/dependabot/npm_and_yarn/acorn-5.…
9915940 
…7.4' into bugfix/22/remove-cached-instance
@Drarok
Merge remote-tracking branch 'origin/dependabot/npm_and_yarn/y18n-4.0…
170e62b 
….1' into bugfix/22/remove-cached-instance
@Drarok
Merge remote-tracking branch 'origin/dependabot/npm_and_yarn/lodash-4…
b1daf10 
….17.21' into bugfix/22/remove-cached-instance
@Drarok
Add test confirming bug joelcolucci#22
ce0f4bc
@Drarok
Remove cached instance of Quill to avoid errors polluting later runs
4e0aa47
@Drarok
Disable memory leak test since leakage hasn't worked in years
eabe02e
@Drarok
Update URLs and name to reflect fork, bump minor version
e7ff196
@Drarok Drarok merged commit d6365ca into master Jun 23, 2021
@Drarok Drarok deleted the bugfix/22/remove-cached-instance branch June 23, 2021 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@Drarok