Crawler properties does not work

[datagutten]

Overriding the properties in CrawlerBase does not work. Properties like history_capable_date always use the default value from CrawlerBase even if they are overridden in a Crawler class.
It works if I remove the type hints, but I have not found any way to make it work with type hints.

comics/comics/aggregator/crawler.py

Line 80 in 899c2ac

history_capable_date: Optional[str] = None

[datagutten]

It seems like the solution is to add the @dataclass decorator to all Crawler classes and add type hints to the properties, like this example from the "lunchtu" crawler:

@dataclass
class Crawler(CrawlerBase):
    history_capable_days: int = 20
    schedule: str = "Mo,Tu,We,Th,Fr"
    time_zone: str = "Europe/Oslo"

With these changes, history capability work as it should, and the status page show the correct schedule:

[jodal]

You're right. According to https://docs.python.org/3/library/dataclasses.html#inheritance, subclasses of dataclasses also need the @dataclass decorator.

I'd consider switching from dataclasses to pydantic, which should only require changes to the CrawlerBase class. Then we might also get better validation of the data specified in the subclasses.