Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github error #55

Open
slebedeva opened this issue Oct 2, 2022 · 4 comments · May be fixed by #68
Open

github error #55

slebedeva opened this issue Oct 2, 2022 · 4 comments · May be fixed by #68

Comments

@slebedeva
Copy link

I cannot save file to github, getting "Error: Could not save file."
I tried renaming main to master.
If I upload a .ly file to sheet-music/master, I can open it in hacklily.org. But I again cannot save it.
Firefox / Ubuntu 22.04.
Thank you!

@wgruenberger
Copy link

I got the same issue
errors from browser console:
ReferenceError: process is not defined at index.js:2:5305104 at u (index.js:2:3594319) at Generator._invoke (index.js:2:3594072) at Generator.next (index.js:2:3594682) at r (index.js:2:3623087) at a (index.js:2:3623290) index.js:2 Error: Could not save file. at index.js:2:5326433 at u (index.js:2:3594319) at Generator._invoke (index.js:2:3594072) at Generator.throw (index.js:2:3594682) at r (index.js:2:3623087) at l (index.js:2:3623326)
let me me know if i can help, thank you

@jdalbey
Copy link

jdalbey commented Oct 29, 2022

Also having this error appear (in a javascript alert box). Also Firefox on Linux Mint.

@pmatos
Copy link

pmatos commented Feb 3, 2023

Same here. I tried it today for the first time and hacklily cannot save files.

@davekobrenski
Copy link

@jocelyn-stericker - this appears to be because the process.env vars aren't available on the client side. The fix is easy: in your webpack.config.js, add this right above the webpack.EnvironmentPlugin declaration:

new webpack.DefinePlugin({
   'process.env': JSON.stringify(process.env)
}),

I'm able to save to my GitHub repo now (using my own org's credentials, for testing).

Just to be safe, I also added "node": true to the "env" section of the .eslintrc.js file (although I'm not sure it's needed).

"env": {
  "browser": true,
  "es6": true,
  "node": true
},

@davekobrenski davekobrenski linked a pull request Mar 23, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants