Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSVC warning cflags in gnulib.BUILD are not being applied #6

Open
jmillikin opened this issue Oct 10, 2019 · 0 comments
Open

MSVC warning cflags in gnulib.BUILD are not being applied #6

jmillikin opened this issue Oct 10, 2019 · 0 comments

Comments

@jmillikin
Copy link
Owner

It looks like select({"@bazel_tools//src/conditions:windows_msvc": doesn't work, and it's always falling through to the default case. This causes problems when updating gnulib, because without /we4013 MSVC will silently accept calls to undeclared symbols.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jmillikin