Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning when navigating dirs with shinyFiles #4

Open
jmcvw opened this issue May 3, 2022 · 4 comments
Open

Warning when navigating dirs with shinyFiles #4

jmcvw opened this issue May 3, 2022 · 4 comments

Comments

@jmcvw
Copy link
Owner

jmcvw commented May 3, 2022

Two warnings are printed whenever current directory is changed using the shinyFiles widget.
mrup functionality appears unnaffected (?) so far as I can tell.

The warnings:

Warning in is.null(tree) || is.na(tree) :
  'length(x) = 7 > 1' in coercion to 'logical(1)'

Warning in is.null(files$dir) || is.na(files$dir) :
  'length(x) = 2 > 1' in coercion to 'logical(1)'

The warning appears on Mac, haven't checked Windows yet. - Have now, and it does.

There here have been a couple of recent changes in the shinyFiles repo that I maybe need to account for.

@jmcvw
Copy link
Owner Author

jmcvw commented May 4, 2022

An issue has been opened on the shinyFiles repo

@pakom
Copy link

pakom commented May 4, 2022

I have found this to be an issue on Windows too. Will test it on Linux and will get back.

@jmcvw
Copy link
Owner Author

jmcvw commented May 4, 2022

I think it looks likely to be related to the chaged behaviour of && and ||, so I would expect it to occur on any OS running R 4.2.

Thanks for opening the issue. I was busy digging into my own code to see if it was something I broke.

@pakom
Copy link

pakom commented May 4, 2022

Yes, I did dig into my own code last night and finally got it.
I can now confirm this issue appears in both Windows and Linux.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants