Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jk format - prettier without any setup #266

Open
dlespiau opened this issue Sep 15, 2019 · 1 comment
Open

jk format - prettier without any setup #266

dlespiau opened this issue Sep 15, 2019 · 1 comment
Labels
kind/enhancement New feature or request topic/cli

Comments

@dlespiau
Copy link
Member

dlespiau commented Sep 15, 2019

It'd be nice to start working towards integrating some common toolchain-things in jk itself. This is taking the nice properties of the go toolchain which integrates linting, formatting, testing, ... and doesn't need the user to do anything.

We could:

  • embed prettier in the standard library and call it from a jk format command
  • ship a default config file
  • Allow overrides if the user wants something different, namely local config files take precedence over the embedded one.
  • This should work for both js and ts.
@dlespiau dlespiau added kind/enhancement New feature or request topic/cli labels Sep 15, 2019
@dlespiau
Copy link
Member Author

dlespiau commented Nov 4, 2019

prettier offers a compiled standalone.js package (https://prettier.io/docs/en/browser.html):

It should be somewhat straight forward to write jk format command built around this standalone.js.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request topic/cli
Projects
None yet
Development

No branches or pull requests

1 participant