Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should function declarations be highlighted in Java? #132

Open
IceMan81 opened this issue Sep 7, 2016 · 5 comments
Open

Should function declarations be highlighted in Java? #132

IceMan81 opened this issue Sep 7, 2016 · 5 comments

Comments

@IceMan81
Copy link

IceMan81 commented Sep 7, 2016

Thinking out loud if its useful to have function declarations highlighted in a different color like the Intellij Darcula scheme. I find them useful at times.

Looking at this screenshot from the solarized page, it looks like the default solarized scheme also applies the idea to Ruby and the intellij color scheme does apply it for Python, so why not for Java?
solarized-fontsamples-light

@aik099
Copy link
Contributor

aik099 commented Sep 7, 2016

On provided screenshot all files are in Ruby. Can you please attach screenshot from Java and indicate what word should have what color?

@jkaving
Copy link
Owner

jkaving commented Sep 7, 2016

On the official Solarized page the Java example does not have highlighted method declarations.
I don't know whether there is a reason for this difference between the languages.

Java example

@IceMan81
Copy link
Author

IceMan81 commented Sep 7, 2016

That's my thought as well, why the Java color scheme does not have method declarations highlighted. Maybe there were Java editors did not provide the option for it, though that seems unlikely.
There does not seem to be a good reason to not have it hightlighted. Some of the eclipse Solarized color schemes I came across are setting it the color in the Ruby screenshot above.

But that color has already been used for Doc Comment tag value.

@IceMan81
Copy link
Author

IceMan81 commented Sep 8, 2016

Maybe not the best idea, but could just make them bold. I'm trying that out now on my work instance. I feel highlighting the method declaration helps, not sure if bold is the way to go.

@IceMan81
Copy link
Author

I've now settled on just underscore on the function name using base1 (light) or base01 (dark). I tried a bunch of different combinations and I liked this the best.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants