Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File dependencies are not scanned #282

Open
Zuplyx opened this issue Mar 4, 2024 · 0 comments
Open

File dependencies are not scanned #282

Zuplyx opened this issue Mar 4, 2024 · 0 comments

Comments

@Zuplyx
Copy link
Contributor

Zuplyx commented Mar 4, 2024

Currently the plugin does not scan file dependencies. While such dependencies do not have any associated metadata, they usually have a manifest which could be scanned for license information.

I think this could be implemented without too much effort in the ConfigurationReader. Currently we are only iterating over ResolvedDependency here:

for (ResolvedDependency dependency : configuration.resolvedConfiguration.lenientConfiguration.getFirstLevelModuleDependencies()) {

To process file dependencies we would also have to iterate over all dependencies which are an instance of FileCollectionDependency and scan all contained files.

@jk1 What are your thoughts about this? I would be willing to provide a PR for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant