Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DANGEROUS BEHAVIOUR WHEN PRESS ENTER AT COMMAND TOOLBAR WITH HISTORY ACTIVATED. #931

Open
fdelcastillo-calimaco opened this issue Mar 3, 2024 · 0 comments

Comments

@fdelcastillo-calimaco
Copy link

fdelcastillo-calimaco commented Mar 3, 2024

Describe the bug
If you have enabled the history option with 1 or more days configured, and you are using dangerous commands like "rm" or "rm -fr", and at any moment you need, press enter with out any command, to only insert the enter without running anything, then any of the saved commands are randomly launched and executed. If that command is "rm" it could be a very big problem.

To Reproduce
Steps to reproduce the behavior:
1.- Activate the history. Set a number of 1 or high for days.
2.- Open a ssh connection.
3.- Launch 1 or 2 linux commands. BE CAREFULL, inoffensive commands like pwd or ls. Be sure you are not using rm or rm -fr to check it and you are inside a test directory and not the / .
4.- Press enter at the "commads" toolbar and you can see how pwd or ls are launched instead of the return.

Expected behavior
Only insert the enter/return to the shell/cmd and DON'T RUN ANY COMMAND.

Desktop (please complete the following information):

  • OS: Checked at W10 and W11 with Version 5 and some superputty versions after 1.4.0.6

Thanks in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant