Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Django System Check Framework to check validity of defined tables #842

Open
waseem-omar opened this issue May 9, 2022 · 0 comments
Open

Comments

@waseem-omar
Copy link

Hi all, thank you for building such an awesome library!

I have a suggestion to use Django System Check Framework to check if table classes and their columns are defined properly before rendering the table.

For example, Column.empty_values attribute is expected to be a list or tuple, and can become problematic in some cases if it is set as a string. With System Check, such issue can be caught upon application startup instead of facing an error upon rendering the table.

This can become a big change and may be of a low priority, however, we can start by registering a checker for django_tables2 that checks for empty_values attribute type, and add to it incrementally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant