Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure AD support in Security #651

Open
1 task done
A-5ingh opened this issue Mar 24, 2021 · 11 comments
Open
1 task done

Azure AD support in Security #651

A-5ingh opened this issue Mar 24, 2021 · 11 comments
Labels

Comments

@A-5ingh
Copy link
Contributor

A-5ingh commented Mar 24, 2021

Overview of the feature request

Looking for Azure AD authentication and authorization support in the monolith application which gets generated through the blueprint.

Motivation for or Use Case

Most of our applications which we develop uses Azure AD authentication and are always deployed in Azure cloud. We often use this blueprint to generate both backend and frontend for our applications. I can surely contribute towards implementing Azure AD authentication support but will require guidance and support.

Related issues or PR
  • Checking this box is mandatory (this is just to show you read everything)
@A-5ingh A-5ingh changed the title Azure AD support Azure AD support in Security Mar 24, 2021
@nicolas63
Copy link
Member

Yes, i think is a good idea, i have never use azure ad have you a sample app ?
All security configuration is done here -> https://github.com/jhipster/jhipster-dotnetcore/blob/main/generators/server/templates/dotnetcore/src/Project/Configuration/SecurityStartup.cs.ejs

@A-5ingh
Copy link
Contributor Author

A-5ingh commented Mar 25, 2021

Thanks @nicolas63
Microsoft has provided enough sample applications which is using msal v2 - https://docs.microsoft.com/en-us/azure/active-directory/develop/sample-v2-code. It include samples for dotnetcore, react, angular etc. Please take a look and let me know what you think.
I'll go through the SecurityStartup.cs.ejs file to understand how it works because this is the first time I'll be working on it.

@nicolas63
Copy link
Member

@nicolas63
Copy link
Member

if you want you can update a generated app and them i can help you to integrate this in the genrator

@A-5ingh
Copy link
Contributor Author

A-5ingh commented Mar 27, 2021

Sure @nicolas63 let me see what can I do, but Azure Ad will require changes in both frontend and backend side. Just like the way oAuth and Jwt authentication have changes in both frontend and backend. I might take some time on getting this done.

@nicolas63
Copy link
Member

do you really need change in front ? it's not just a redirect to azure ad login page ?
The easiest way would be to generate an application and then make modification. After that, I can help you to integrate it in the generator.

@A-5ingh
Copy link
Contributor Author

A-5ingh commented Mar 31, 2021

@nicolas63 Yes frontend code will definitely require change so that on login it will redirect to correct azure ad login page. It requires a library MSAL Microsoft authentication library, which will perform the protection of routes and post login/logout redirects.

Sure, let me do some initial analysis and then will work on the generated app to implement azure ad at backend first. After that we can check the frontend part.

@b509
Copy link

b509 commented Jul 6, 2021

Hi,
were you able to make any progress on this? I am trying to do the same with Java Spring Security and Azure AD, but struggling.

@nicolas63
Copy link
Member

@b509 sorry any progress on this issue but if you have the time to provide me an example I can help you to integrate the example in the generator

@nicolas63
Copy link
Member

@b509 if you need only spring security i think you need to create an issue here https://github.com/jhipster/generator-jhipster

@manishkungwani
Copy link

Hi @nicolas63 Is the repo being maintained?
Are you still open to adding Azure AD login as one of the options?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants