Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.gitignore must NOT ignore .idea/ folder #27708

Open
1 task done
earizon opened this issue Oct 28, 2024 · 4 comments
Open
1 task done

.gitignore must NOT ignore .idea/ folder #27708

earizon opened this issue Oct 28, 2024 · 4 comments

Comments

@earizon
Copy link

earizon commented Oct 28, 2024

Overview of the issue

.gitignore removes .idea from git, but .idea has been designed to be versioned and shared in .git
Only a few files inside .idea/ must not be versioned as explained in:
https://intellij-support.jetbrains.com/hc/en-us/articles/206544839-How-to-manage-projects-under-Version-Control-Systems

NOTE: idea itself add an .idea/.gitignore file, so it is quite safe to just remove .idea from .gitignore.

Motivation for or Use Case

Sharing .idea folder is a "best pattern".

Reproduce the error

Any new project inherits the .gitignore with the extra ".idea" line.

Suggest a Fix

Remove .idea from .gitignore.

JHipster Version(s)

tested in latest version.

JHipster configuration

N/A

Browsers and Operating System

Browser/OS independent.

  • Checking this box is mandatory (this is just to show you read everything)
@earizon earizon changed the title .gitignore must NOT ignore .idea. .gitignore must NOT ignore .idea/ folder Oct 28, 2024
@mraible
Copy link
Contributor

mraible commented Oct 28, 2024 via email

@atomfrede
Copy link
Member

Me too, but I was not aware it contains stuff to be shared and I never tried it on any of my teams.

@amatosg
Copy link
Contributor

amatosg commented Nov 27, 2024

Personally, I like to ignore .idea/ in .gitignore. Mostly because I don't expect other developers to use IntelliJ IDEA.

I think the same, but it doesn't hurt to have it there just in case another user uses IntelliJ. Is just a plus

@wangxinxx
Copy link
Contributor

Personally, I like to ignore .idea/ in .gitignore. Mostly because I don't expect other developers to use IntelliJ IDEA.

The increase in the number of participants at any time and the more personalized content may have negative effects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants
@mraible @atomfrede @mshima @earizon @wangxinxx @amatosg and others