Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate with rack-mini-profiler #36

Open
jhawthorn opened this issue Nov 12, 2023 · 4 comments
Open

Integrate with rack-mini-profiler #36

jhawthorn opened this issue Nov 12, 2023 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers Ruby Should be completable in Ruby (no C++)

Comments

@jhawthorn
Copy link
Owner

An easy way to get profiling data from a running web server is to have a Rack middleware, which wraps the current request in a profile and returns the profile of the request instead of the original body.

At work we use a custom middleware for this, but for other projects I really like https://github.com/MiniProfiler/rack-mini-profiler

We could propose Vernier support is added to rack-mini-profiler (I don't know if they're open to it), or make our own middleware (would avoid needing to install an extra gem), or both!

@jhawthorn jhawthorn added enhancement New feature or request good first issue Good for newcomers Ruby Should be completable in Ruby (no C++) labels Nov 12, 2023
@technicalpickles
Copy link
Contributor

@nateberkopec (as a rack-mini-profiler) how would you feel about vernier support?

@nateberkopec
Copy link

100%, we're in 👍

@jhawthorn jhawthorn changed the title Add Rack middleware Integrate with rack-mini-profiler Apr 24, 2024
@willtcarey
Copy link

Hey @jhawthorn, I'm interested in moving this one forward. For the existing visualization in RMP they vendor Speedscope into the gem. As we talked at RailsConf, doing something like that may work best for this as well. However I haven't seen the repo for the visualizer anywhere, could you point me in that direction?

@jhawthorn
Copy link
Owner Author

@willtcarey @richardkmichael Sorry for the slow reply, yes https://vernier.prof/ and profile-viewer https://github.com/tenderlove/profiler which is also barely different than what's on https://profiler.firefox.com/

I'd love to see this integrated into rack-mini-profiler, be that a full integration which includes the profiler frontend (which should be possible, it's a single page app) or even just downloading profile files as a starting point I think would be an improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers Ruby Should be completable in Ruby (no C++)
Projects
None yet
Development

No branches or pull requests

4 participants