Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http. RoundTripper is not re-used #10

Open
pavelmemory opened this issue Nov 9, 2021 · 1 comment
Open

http. RoundTripper is not re-used #10

pavelmemory opened this issue Nov 9, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@pavelmemory
Copy link
Contributor

For the bitbucketserver and github vcsclient(s) the http.RoundTripper is not re-used, but created for each new request if client.vcsInfo.Token is provided.
This can cause an issue because connections acquire file descriptors and won't be released immediately after http.Client garbage collection, please see https://golang.org/src/net/http/transport.go#L68
@pavelmemory pavelmemory changed the title http.Client is not re-used http. RoundTripper is not re-used Nov 9, 2021
@yahavi yahavi added the bug Something isn't working label Jan 11, 2022
@eyalbe4
Copy link
Contributor

eyalbe4 commented Jan 26, 2022

@pavelmemory,
Thanks for reporting this issue.
We'd be happy to accept a fix for this issue through a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pavelmemory @eyalbe4 @yahavi