Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHPUnit Tests Are Failing #48

Open
dac514 opened this issue Nov 7, 2019 · 1 comment
Open

PHPUnit Tests Are Failing #48

dac514 opened this issue Nov 7, 2019 · 1 comment

Comments

@dac514
Copy link

dac514 commented Nov 7, 2019

I wanted to try to submit a PR but I gave up because the tests are failing. Please fix?

  1. ImplementationTest::testEqualHashes with data set Use binary operations to calculate the hamming distance #5 (Jenssegers\ImageHash\Implementations\BlockHash Object (...))
    Undefined offset: 8

  2. ImplementationTest::testDifferentHashes with data set Use binary operations to calculate the hamming distance #5 (Jenssegers\ImageHash\Implementations\BlockHash Object (...))
    Undefined offset: 8
@dac514 dac514 mentioned this issue Nov 7, 2019
Merged
dac514 added a commit to pressbooks/pressbooks that referenced this issue Nov 7, 2019
@dac514
Downgrade imagehash 0.5.0 (without phpseclib) (#1827)
7cf2898 
jenssegers/imagehash#49
jenssegers/imagehash#48
@jenssegers
Copy link
Owner

Looking into it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jenssegers @dac514