New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3 months ago Polish translations were reverted to incorrect forms #320
Comments
@UnrulyNatives I guess some users use Jenssegers in sentences where months are not in Genitive. So for them, your fix breaks their workflows. So what we really need to do is providing a way to apply the Nominative/Genitive dynamically as moment.js do: Can you check if moment.js function is right. Then if it is, please propose a pull-request to Carbon: Carbon 2 handle dynamic cases, for example, ru.php take months_standalone instead of months when the format (considered with the isoFormat() method pattern) matches the months_regexp: |
I checked with moment.js and planned to do this: That would be the correct way to handle it. Else you will always have someone that get an incorrect result for his own case. |
Fixed in 4.0.0. |
Please undo the last commit of the file
lang/pl.php
In Polish language in dates the name of the month must be in Genitive case.
Please refer to theseEnglish sources:
http://www.mediawiki.org/wiki/Template:I18n_month
http://stackoverflow.com/questions/17188316/month-name-in-genitive-polish-locale-with-joda-time-datetimeformatter
Additional remark:
Is it possibe to somehow lock the file against disrupting changes? This is the second time I need to manually downgrade your package to version which displays month names properly. Maybe we could put a remark in a comment inside of the file?
The text was updated successfully, but these errors were encountered: