Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

laravel 8 support? #178

Open
yaowei520 opened this issue Sep 11, 2020 · 3 comments
Open

laravel 8 support? #178

yaowei520 opened this issue Sep 11, 2020 · 3 comments

Comments

@yaowei520
Copy link

No description provided.

@mfn
Copy link

mfn commented Sep 11, 2020

@yaowei520 is there anything specifically not working?

The package provides a Laravel service provider but besides that has no e.g. version constraints, see

agent/composer.json

Lines 13 to 21 in 1bacac5

"require": {
"php": ">=5.6",
"mobiledetect/mobiledetectlib": "^2.7.6",
"jaybizzle/crawler-detect": "^1.2"
},
"require-dev": {
"phpunit/phpunit": "^5.0|^6.0|^7.0",
"php-coveralls/php-coveralls": "^2.1"
},

@jason-klein
Copy link

I successfully installed your package into a Laravel 8 application without any modifications.

I expected a conflict since your package requests PHPUnit 5/6/7, but Laravel 8 uses PHPUnit 9. Just FYI in case OP can confirm they are receiving a PHPUnit conflict during install. The PHPUnit 9 requirement is listed in the Laravel 8 Upgrade Guide and in the Laravel 8 composer file.

https://github.com/laravel/laravel/blob/c6c41f11b8ea3065f035fbb6a6f570b7bfba0037/composer.json#L18-L24

@jangaraev
Copy link

Confirm that it works on L8 project absolutely well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants