Skip to content
This repository has been archived by the owner on Nov 27, 2018. It is now read-only.

Liberty pack doesn't work with provided quick start #69

Open
davidcurrie opened this issue Aug 31, 2018 · 1 comment
Open

Liberty pack doesn't work with provided quick start #69

davidcurrie opened this issue Aug 31, 2018 · 1 comment

Comments

@davidcurrie
Copy link

The liberty pack doesn't work with the provided Open Liberty quick start. The getting started app used for the quick start uses features that aren't in the default server.xml provided in the open-liberty/openliberty:javaee7 image. Also, the probePath specified in the values.yaml for the chart isn't going to work as the sample application uses MicroProfile health which uses /health.

I'm going to seek opinions on the Open Liberty mailing list as to the right answer for the first part. Ideally you'd be copying the server.xml in along with the app but that also means switching from using dropins to apps where you'll run in to trouble with the versioned naming of the WAR file. I suspect in the end changes will be needed both here and in the quick start.

For the probe you just need to decide whether you think Spring or MicroProfile is the more likely scenario.

@davidcurrie
Copy link
Author

I've submitted two PRs to at least get the Liberty path working with the quick start:
jenkins-x-quickstarts/open-liberty#4
#74

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant