Skip to content
This repository has been archived by the owner on Nov 27, 2018. It is now read-only.

golang pack go lint can't handle dir with a : in the name #53

Open
rawlingsj opened this issue Jul 17, 2018 · 0 comments
Open

golang pack go lint can't handle dir with a : in the name #53

rawlingsj opened this issue Jul 17, 2018 · 0 comments

Comments

@rawlingsj
Copy link
Member

From slack a user with bitbucketserver tried the golang quickstart but it fails in the release pipeline with

Makefile:24: *** target pattern contains no `%'.  Stop.

This can be recreated by creating a golang quickstart in your go path under a git server that includes a : port e.g.

~/go/src/mybitbucketserver:1234/rawlingsj/foo

Now run make build in that folder.

The issue is the paths that go list ./... | grep -v /vendor | grep -v generated from https://github.com/jenkins-x/draft-packs/blob/dfda4a9/packs/go/Makefile#L9 returns contain the : which causes issues in the Makefile targets.

A hack to get the quickstart going in this scenario was to replace : with _ in the PKGS var but that disabled the lint so is a pretty horrid workaround.

We should come up with a way to escape or workaround better.

rawlingsj added a commit to jenkins-x-quickstarts/golang-http that referenced this issue Jul 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant