-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bunch of minor issues #84
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Thanks for your work on this emulator, I've been using the CPU emulation to help find bugs in an x86 emulator I've been writing. In the process I've noticed a few issues in PCjs so I'm reporting them here.
fnXCHGrw
inx86func.js
has a typo for the[E]BP
case - it refers tothis.regEBX
rather thanregEBP
.loadDesc8
insegx86.js
assignsfIDT
only if(sizeGate > 0)
but it's possible to hit a usage without it being assigned (in the!(acc & X86.DESC.ACC.PRESENT)
case).loadDesc8
the memberthis.addrIOPMLimit
is assigned using the value ofthis.limit
but I believe it should be using the local variablelimit
.Things that I'm not entirely sure about the correct behaviour:
AAD
in particular is different). I haven't myself confirmed whether the test suite is correct but you might be interested in it.Once again thanks for providing this emulator - it has helped me track down many tricky bugs in my emulator and the code is nicely modular and readable so I was able to run it synchronised with my emulator and compare the execution.
The text was updated successfully, but these errors were encountered: