Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible bug about skipping elements #2

Open
zh217 opened this issue Jul 17, 2024 · 1 comment
Open

Possible bug about skipping elements #2

zh217 opened this issue Jul 17, 2024 · 1 comment

Comments

@zh217
Copy link

zh217 commented Jul 17, 2024

I may have misunderstood the intention but in several places the element at index 0 is not taken into account when computing minhashes:

for i in 1..nb_elem {

for i in 1..nb_elem {

@jean-pierreBoth
Copy link
Owner

Thanks. And also in setsketcher. impacts for small sketch slices at low j values, just the opposite of my main use. Will push a fix asap (and make a clippy pass)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants