Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove token-requirement on APIs that work without authentication #173

Closed
dotWee opened this issue Aug 24, 2018 · 4 comments · Fixed by #3588
Closed

Remove token-requirement on APIs that work without authentication #173

dotWee opened this issue Aug 24, 2018 · 4 comments · Fixed by #3588

Comments

@dotWee
Copy link

dotWee commented Aug 24, 2018

Some of the APIs GitLab provides are usable without a user generated token, like the /users/:user_id/projects path (reference):

Get a list of visible projects owned by the given user. When accessed without authentication, only public projects are returned.

It would be awesome to use those without getting an token is mandatory error!

@jdalrymple
Copy link
Owner

jdalrymple commented Aug 24, 2018

For the time being, I could remove the requirement for a token and anything that does require a token would just error out :s not the most elegant solution but until we add the proposed mapping in #104 , it would be a waste of time to implement throughout all the services.

@dotWee
Copy link
Author

dotWee commented Aug 25, 2018

Please correct me if I'm wrong, but wouldn't error'ing out result in just like any request with an invalid token? aka. the implemented StatusCodeError: 401 Unauthorized
Anyway, an implementation after #104 seems reasonable.

@jdalrymple
Copy link
Owner

Yup! Which is still pretty clear of a message. Ill make a PR this weekend.

jdalrymple added a commit that referenced this issue Aug 28, 2018
jdalrymple added a commit that referenced this issue Aug 28, 2018
* fix: Removing token requirement #173

* chore: Updating npmignore to decrease package size
@michael-smt
Copy link
Contributor

It would be great to have this possibility again in the newest version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants