-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Codenames Pictures #83
Comments
I think it might be tricky to support without pretty extensive changes, but I agree it would be cool! I'll think on it... |
Here's a quick fork for Codenames Pictures. I had to change some CSS to get the cards to be a bigger, so that the images are clearer. So in this fork there is no support for the ordinary Codenames. It should be possible to have the two working side by side, though. WDYT? |
@zvikabh |
That fork is just an example for illustrative purposes, I don't own the copyright for those images. |
@zvikabh |
I just wanted to illustrate that this is easy to do technically. I suppose you're right and to be safe, I removed the images. |
OK, I set up a new version in which I carefully verified that all images are public domain. You can also try it out here: http://ec2-18-188-243-7.us-east-2.compute.amazonaws.com/ |
@zvikabh |
Most are from freesvg.org, and a few from Wikipedia, some with a couple of minor tweaks of my own. You are welcome to use them. |
I liked your idea to use SVG instead of PNG. Thanks for sharing. |
Cool, LMK if you get some nice results with your fork. |
Hey fam, I have a functioning and hosted version of Codenames Pictures here: https://github.com/banool/codenames-pictures. This has been alive for maybe 1.5 years now. It's a fork of this repo and like you all predicted, I had to make pretty heavy, backwards-incompatible changes to the code. As such, I've fallen way behind master because it isn't feasible to pull the new code in without essentially rewriting it all (though I'd be interested to try some time). It'd be interesting to see how the original project could be refactored to support pictures natively, perhaps with some easily overwritable component for each of the cells in the game board. I had to make backend changes to support serving up URLs instead of words also of course. To get around attribution issues, my friends and I drew our own cards 🤠. There is also support for using custom images supplied by the user. For example, try putting |
@banool, |
Guys we should absolutely make CodeMEMES |
Support for Codenames Pictures (perhaps as a separate language?) would be totally awesome. Are there any thoughts along these lines?
I'm willing to contribute a bunch of Codenames Pictures-like drawings of mine. I can also have a go at coding, but I'm not very experienced with Go, so any pointers on how to go about this would be awesome.
The text was updated successfully, but these errors were encountered: