-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TimeInDayLight - error when calculating local almanac #405
Comments
I got the same error via R, it was reported here opengeos/whiteboxR#74 |
Copying response from end of opengeos/whiteboxR#74 Originally posted by @brownag in opengeos/whiteboxR#74 (reply in thread) I can confirm I get the same error on Linux. Via the R interface or via the command line. I tinkered with some of the parameters and same result. I notice there were some changes (NaiveTime -> Time, NaiveDate -> Date) in how time is handled in this tool for WhiteboxTools v2.3: 4208336#diff-4c6d03f9fd598a5f68bf881cd140eedc9642af3e07fa7bdc0d062f291adba587 Based on the error output 2024 is a leap year, 2023 is not. Previous code used 2020. It looks like the code (Line 934 in time_in_daylight.rs) might be hard-coded to use 2023, but is iterating over day of year 1 to 366. whitebox-tools/whitebox-tools-app/src/tools/terrain_analysis/time_in_daylight.rs Lines 934 to 941 in 4208336
|
I'm trying to use the Time In Day Light tool, but the following error is raised (with the QGIS pluggin and the python interface) :
When i'm looking to the script, it seems that the script is triying to access to the 366 day of 2023, which it not exists.
https://github.com/jblindsay/whitebox-tools/blob/master/whitebox-tools-app/src/tools/terrain_analysis/time_in_daylight.rs#L935
The text was updated successfully, but these errors were encountered: