Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ComfyUI integration #5

Open
jbilcke-hf opened this issue Jun 18, 2024 · 8 comments
Open

Improve ComfyUI integration #5

jbilcke-hf opened this issue Jun 18, 2024 · 8 comments
Labels
bounty $$$ This ticket has a financial reward attached to it new feature to refine This issue cannot be taken just yet, it needs spec refinement

Comments

@jbilcke-hf
Copy link
Owner

jbilcke-hf commented Jun 18, 2024

Context

ComfyUI is all the rage right now, and I would like to use it as one of the supported backends for Clapper.

Currently, Clapper only has ultra-basic support for ComfyUI cloud providers, such as Comfy.icu (see this screenshot, the ugly text field at the very bottom):

Screenshot 2024-07-25 at 20 52 32

Goal

At minimum, it should be able to use an existing integration running locally or in the cloud

But what I have in mind is more something like this:

  • a list of available workflows straight from from the global ComfyUI community, such as OpenArt.ai
  • a way to easily pick them, eg. click "apply", "use", "install", or some as simple as a drag & drop
  • a display of the workflow within the UI (eg. preview of the comfy graph)

Limitations / things to checks

I'm not a ComfyUI developer (or user), so it's gonna be a fun ticket!

How to implement

For now I've only added some basic code that doesn't really work (search for "comfy" and "ComfyIcu" - it's related to comfy.icu - in the codebase)

Acceptance criteria

Being able to run any ComfyUI workflow, for : image, video, and why no also sound, voice and music

@jbilcke-hf jbilcke-hf added new feature to refine This issue cannot be taken just yet, it needs spec refinement and removed enhancement labels Jul 4, 2024
@lalalune
Copy link
Collaborator

lalalune commented Jul 9, 2024

/boss $250

Copy link

boss-bounty bot commented Jul 9, 2024

Total Bounty: $1050

Bounties

Bounties paid automatically on close:

@jbilcke-hf jbilcke-hf added the bounty $$$ This ticket has a financial reward attached to it label Jul 11, 2024
@sendn0des
Copy link
Collaborator

Flexibility to pull from openart.ai would present some wonk. There's too many workflows and many are meh - but it could lead to an issues with frontend design later attempting to accommodate.

I'll bring over some workflows I've considered or have that would play well and can design toolkit around them.

@lalalune
Copy link
Collaborator

/boss $500

@jbilcke-hf
Copy link
Owner Author

jbilcke-hf commented Jul 25, 2024

I'm making some changes to the codebase to prepare and facilitate work for this ticket.

These changes are not specific to ComfyUI, so not in the scope of this ticket, and not meant to claim the bounty:

  1. I've added the concept of workflow to Clapper and the project file format (OpenClap):
    (import { ClapWorkflow } from "@aitube/clap"))

  2. A .clap project (import { ClapProject } from "aitube/clap") can now embed an array of generic workflows (clap.workflows = [] // type ClapWorkflow[])

  3. A timeline segment (import { ClapSegment } from "aitube/clap") can now optionally reference a workflow id (segment.workflowId = "..."). Right now this will do nothing, but the idea is that the workflow should be called to generate the corresponding segment's output value. (I advise to use this with parcimony, to avoid using +100 different workflows within your project (you could, but I'm not sure it would be wise). Instead I encourage to use a default workflow for image, another default workflow for video, another for sound, music etc..)

  4. A workflow can have an array of parameters, and default values

  5. there is now a empty WorkflowEditor, to be worked on later. The idea is to add a UI to be able to visualize, edit and set the default parameters of workflows (again it's not about ComfyUI but any AI workflow engine like Transformers.js, MediaPipe, Visual Blocks, Glif etc)

@sendn0des
Copy link
Collaborator

love the idea of specific workflows. will avoid the comfy ecosystem compatibility and deprecated node issues.

glif could be useful here since the workflows are managed internally and maintained

for later, comfydeploy looks interesting for rapid iteration. it has a nice desktop workflow -> deploy -> frontend setup

@jbilcke-hf
Copy link
Owner Author

jbilcke-hf commented Aug 12, 2024

I have made some improvements to the code to improve ComfyUI support (a real ComfyUI server that you run locally or on your own remote server)

I believe we are close to having a basic (static) demo soon, hopefully this week

@nha1012
Copy link

nha1012 commented Sep 27, 2024

/boss $300

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bounty $$$ This ticket has a financial reward attached to it new feature to refine This issue cannot be taken just yet, it needs spec refinement
Projects
Status: No status
Development

No branches or pull requests

4 participants