Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pip-compile should not generate a command with --output-file if the output file matches the configuration #2094

Open
aentwist opened this issue May 16, 2024 · 2 comments

Comments

@aentwist
Copy link

Expected

pyproject.toml

[tool.pip-tools]
src_files = ["requirements.in", "dev-requirements.in"]
output_file = "requirements-lock.txt"

output command is pip-compile

Actual

#
# This file is autogenerated by pip-compile with Python 3.10
# by the following command:
#
#    pip-compile --output-file=requirements-lock.txt
#

very low prio

@chrysle
Copy link
Contributor

chrysle commented May 16, 2024

Hmm, why do you think it shouldn't? If it is configured, it is something specified by the user (although indirectly).

@aentwist
Copy link
Author

aentwist commented May 17, 2024

Well with the configuration in place it would mislead people as to the minimum of what they have to do. I can appreciate the thing being as if there is no configuration in place. In that case, src_files should also be represented. Because of the inconsistency between src_files and output_file in the output command I think it just struck me as a bit off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants