Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why depend on django-phonenumber-field? #245

Open
danielquinn opened this issue Jan 31, 2018 · 2 comments
Open

Why depend on django-phonenumber-field? #245

danielquinn opened this issue Jan 31, 2018 · 2 comments

Comments

@danielquinn
Copy link
Contributor

Expected Behavior

If this project can run without using phone number stuff for 2fa, then having it as a base dependency seems excessive, especially when you've already got Call defined in extras_requries=.

Current Behavior

Installing django-two-factor-auth pulls in django-phonenumber-field, which in turn brings in phonenumberslite, but if you're not using any of the SMS features, these are all loaded for no reason (as far as I can tell)

Possible Solution

Move django-phonenumber-field into extras_require= inside Call and SMS.

Context

I'm running into problems with phonenumberslite in the area of dependencies & updates etc. I know I'm not doing anything with phones, so I started digging to find out why this is being pulled in at all.

Your Environment

  • Browser and version: Firefox 58.01
  • Python version: 3.6.4
  • Django version: 1.11
  • django-otp version: 0.4.2
  • django-two-factor-auth version: 1.7.0
@Bouke
Copy link
Collaborator

Bouke commented Feb 14, 2018

Historically phone/text support was not optional for this package. Over time phone/text support has increasingly been decoupled, however there are still some places where a hard dependency exists. As mention elsewhere in the issues section, it would be nice if this package would adopt a modular design, where multiple OTP systems could be hooked in.

@peymanslh
Copy link
Member

I think this will be fixed when #469 closes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants