You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If this project can run without using phone number stuff for 2fa, then having it as a base dependency seems excessive, especially when you've already got Call defined in extras_requries=.
Current Behavior
Installing django-two-factor-auth pulls in django-phonenumber-field, which in turn brings in phonenumberslite, but if you're not using any of the SMS features, these are all loaded for no reason (as far as I can tell)
Possible Solution
Move django-phonenumber-field into extras_require= inside Call and SMS.
Context
I'm running into problems with phonenumberslite in the area of dependencies & updates etc. I know I'm not doing anything with phones, so I started digging to find out why this is being pulled in at all.
Your Environment
Browser and version: Firefox 58.01
Python version: 3.6.4
Django version: 1.11
django-otp version: 0.4.2
django-two-factor-auth version: 1.7.0
The text was updated successfully, but these errors were encountered:
Historically phone/text support was not optional for this package. Over time phone/text support has increasingly been decoupled, however there are still some places where a hard dependency exists. As mention elsewhere in the issues section, it would be nice if this package would adopt a modular design, where multiple OTP systems could be hooked in.
Expected Behavior
If this project can run without using phone number stuff for 2fa, then having it as a base dependency seems excessive, especially when you've already got
Call
defined inextras_requries=
.Current Behavior
Installing django-two-factor-auth pulls in django-phonenumber-field, which in turn brings in phonenumberslite, but if you're not using any of the SMS features, these are all loaded for no reason (as far as I can tell)
Possible Solution
Move
django-phonenumber-field
intoextras_require=
insideCall
andSMS
.Context
I'm running into problems with phonenumberslite in the area of dependencies & updates etc. I know I'm not doing anything with phones, so I started digging to find out why this is being pulled in at all.
Your Environment
The text was updated successfully, but these errors were encountered: