Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚜 Migrate to django-fsm-2 #188

Open
jefftriplett opened this issue Apr 20, 2024 · 3 comments
Open

🚜 Migrate to django-fsm-2 #188

jefftriplett opened this issue Apr 20, 2024 · 3 comments

Comments

@jefftriplett
Copy link

I recently switched to https://pypi.org/project/django-fsm-2/, and dropping the django_fsm setup requirement would still allow other spiritual successor projects to work.
https://github.com/jazzband/django-fsm-log/blob/master/setup.py#L22

I'm happy to create a new issue and submit a PR if this is helpful?

@lorenzomorandini
Copy link
Contributor

Fine for me, since django-fsm (1) won't be updated anymore I don't see a reason to keep it as dependency. Still we should consider to document this, especially if django-fsm-2 will ever introduce breaking changes with django-fsm.

@pfouque
Copy link
Member

pfouque commented May 16, 2024

especially if django-fsm-2 will ever introduce breaking changes with django-fsm.

That's not the plan! ;)
The main idea is to keep publishing releases according to Python & Django version upgrades.
I may add type hints at some point, but feature-wise, the scope is complete IMO!

@ticosax
Copy link
Member

ticosax commented Dec 17, 2024

Fixed by #192
I will try to make a release shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants