Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StorageDownloadView deprecates PathDownloadView #45

Open
5 tasks
benoitbryon opened this issue Oct 24, 2013 · 0 comments
Open
5 tasks

StorageDownloadView deprecates PathDownloadView #45

benoitbryon opened this issue Oct 24, 2013 · 0 comments

Comments

@benoitbryon
Copy link
Collaborator

Currently (version 1.2), StorageDownloadView inherits PathDownloadView.
Should be: StorageDownloadView makes it easy to PathDownloadView.

  • Add get_storage(), get_storage_class and get_storage_kwargs() methods to StorageDownloadView, i.e. make the storage overridable.
  • By default, get_storage() uses Django's get_storage_class(settings.DEFAULT_STORAGE).
  • In documentation, explain that (deprecated) PathDownloadView is a StorageDownloadView with storage=FileSystemStorage(location=CUSTOM_LOCATION)
  • Deprecate PathDownloadView.
  • Optionally setup a backward-compatible PathDownloadView which inherits StorageDownloadView and uses FileSystemStorage as a default.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant