Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fit into SAI #4

Closed
wants to merge 4 commits into from
Closed

Conversation

michielbdejong
Copy link

@michielbdejong michielbdejong marked this pull request as draft March 5, 2024 10:48
shapetrees:shape <./foafProfile.txt> ;
shapetrees:describesInstance rdfs:label .

<./descriptions-en>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You still need to add those descriptions; I think you should focus on English and remove Spanish below.

<#profileTree>
a shapetrees:ShapeTree ;
shapetrees:expectsType shapetrees:Resource ;
shapetrees:shape <./foafProfile.txt> ;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ShExC syntax registers text/shex media type with .shex file extension.

Comment on lines +19 to +21
* go to http://localhost:4200/applications
* click '+ ADD APPLICATION'
* fill in http://localhost:3600 as the Client ID
Copy link

@elf-pavlik elf-pavlik Mar 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* go to http://localhost:4200/applications
* click '+ ADD APPLICATION'
* fill in http://localhost:3600 as the Client ID
* login at http://localhost:4200/ and connect server
* login at http://localhost:3600 and request authorization

you can find out how to do it at https://github.com/janeirodigital/sai-js/blob/main/examples/vuejectron/src/store/core.ts#L53-L59

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those instructions will fail unless you also add that code into this app, right?
Does the + ADD APPLICATION button not work?

Copy link

@elf-pavlik elf-pavlik Mar 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does work; you still need a valid Client ID document janeirodigital/sai-js#77 (comment)

I still think requesting authorization from the app is more intuitive than making sure one passes a valid client ID into the input field. But since we are currently talking about app developers, it should not matter.


## Add this app to your pod using SAI
In order to add this app to your pod:
* use [this branch of SAI](https://github.com/michielbdejong/sai-js/tree/investigating-77), and run it on localhost according to the instructions there

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the people to request authorization you will need to remove the ldo-react-tutorial one you added.
You will also need to add at least one data registry using your shapetree, for example here https://github.com/janeirodigital/sai-js/tree/main/packages/css-storage-fixture/alice-home/dataRegistry

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if Alice uses this app for the first time and doesn't have the data registry it needs yet?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines +19 to +21
* go to http://localhost:4200/applications
* click '+ ADD APPLICATION'
* fill in http://localhost:3600 as the Client ID
Copy link

@elf-pavlik elf-pavlik Mar 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does work; you still need a valid Client ID document janeirodigital/sai-js#77 (comment)

I still think requesting authorization from the app is more intuitive than making sure one passes a valid client ID into the input field. But since we are currently talking about app developers, it should not matter.

@michielbdejong
Copy link
Author

Superseded by o-development/ldo-tutorial-solid-react#1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants