Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App gets close immediately after release, but without this package works well #25

Open
ghost opened this issue Feb 18, 2020 · 5 comments

Comments

@ghost
Copy link

ghost commented Feb 18, 2020

No description provided.

@mppperez
Copy link
Contributor

Hi,

we had to exclude index.js from transforming by adding it to transformer.js:

const filter = filename => {
	return filename.startsWith("app") // all our sources that should be transformed are in folder app
		&& !filename.startsWith("app/components/index") // skip this file due to NoSuchKeyException
		;
};

Furthermore we've had to add these rules for proguard: https://github.com/facebook/react-native/blob/master/ReactAndroid/proguard-rules.pro

Hope this helps.

Best regards,
Marco

@ghost
Copy link
Author

ghost commented Feb 20, 2020

Thank you, could you please let me know that what is difference between progaur and this package ?

@mppperez
Copy link
Contributor

Proguard is Androids mechanism to obfuscate Java-Files. It looks that it isn't used anymore since Android Gradle Plugin 3.4.0 but it's config files are still used (backwards compatible):

https://developer.android.com/studio/build/shrink-code

@mppperez
Copy link
Contributor

Another tip: use the config parameter "enableInDevelopment" (transformer.js) during development so that such errors are revealed before releasing your app. You can disable it after successful testing afterwards to speed things up again in development mode.

@ghost
Copy link
Author

ghost commented Apr 16, 2020

this package will not affect on performance ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant