-
-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ws{{Action}}Context
classes do not have a pretty getUpgradeContext()
method.
#2216
Comments
The current |
Ah yeah @tipsy did mention this in Discord but I just forgot to mention that here. Feel free to adjust this to be a Bug then, with another Issue span off discussing the lack of API method for Ws related contexts if that'd how you'd like to manage this? :) |
I agree that this is a bug, but unfortunately we can't add this annotation now (the method has been public for years). So I chose feature request rather than bug. |
Describe your issue
The
WsConnectContext
,WsCloseContext
,WsErrorContext
,WsMessageContext
, andWsBinaryMessageContext
classes do not have a pretty way to retrieve the Context that was used during the Upgrade request via the Java Api.The current usage is:
but I'd prefer for the usage to be:
So this change is purely a aesthetic request, the underlying functionality should not change.
The text was updated successfully, but these errors were encountered: