Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assertRequiredHeaders() does not check all headers #6

Open
jiripetrzelka opened this issue Nov 8, 2020 · 1 comment
Open

assertRequiredHeaders() does not check all headers #6

jiripetrzelka opened this issue Nov 8, 2020 · 1 comment

Comments

@jiripetrzelka
Copy link

The $requestHeaders should be lowercased before calling array_intersect() on them with the required headers.
Also, the method does not seem to check the (request-target) header if it is required.
blackwolf-cz added a commit to blackwolf-cz/http-signature that referenced this issue Mar 6, 2021
@blackwolf-cz
fix of jasny#6
dfecead
@jasny
Copy link
Owner

jasny commented Mar 10, 2021 •
edited
Loading

@blackwolf-cz Could you please do a PR with the fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jasny @jiripetrzelka