-
-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Potential bug with route matching #568
Comments
I also believe it is duplicate work because the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I am wondering if I have found a bug or if what I have found is the intended behavior. The bug I believe is the line below
after.js/packages/after.js/src/renderApp.tsx
Line 141 in dbc362f
It passes in
req.url
instead ofpathname
like it does in this fileafter.js/packages/after.js/src/loadInitialProps.tsx
Line 19 in dbc362f
The problem is that
req.url
can contain a query string for examplehttps://example.com/?testing=123
which would makereq.url
equal to/?testing=123
and it would never actually match a route. I discovered this after trying to figure out why thematch
property wasnull
inside of the DocumentgetInitialProps
function. Can someone tell me if this is the intended behavior for some reason?The text was updated successfully, but these errors were encountered: