Skip to content
This repository has been archived by the owner on Feb 2, 2024. It is now read-only.

Simplify the definition of the application host name #167

Closed
dmartinol opened this issue Jan 8, 2024 · 3 comments · Fixed by #169
Closed

Simplify the definition of the application host name #167

dmartinol opened this issue Jan 8, 2024 · 3 comments · Fixed by #169
Assignees
Labels
kind/enhancement New feature or request status/triage

Comments

@dmartinol
Copy link

What do you want to improve?

Simplify the definition of the application host name for a chart deployer.

What is the current behavior?

The chart deployer must specify the application host using either global.host or global.clusterRouterBase.
The latter parameter is basically requesting the user to specify a cluster configuration that we can also extract from the cluster itself with a lookup function.

What is the new behavior?

In the janus-idp.hostname template function, extend the exit condition with a further attempt to lookup the cluster domain from the configuration, as in:
oc get ingress.config.openshift.io/cluster -oyaml | yq '.spec.domain'
If the configuration is found, then we can use it as a last resort option.

@masayag
Copy link

masayag commented Jan 9, 2024

@Zaperex can you pls see if this one is valid and if it can be contributed?

@Zaperex
Copy link
Member

Zaperex commented Jan 9, 2024

@masayag I tested on openshift local and verified that the relevant hostname information can be extracted from the cluster with a lookup function. I'll add the PR for it right now.

@dmartinol
Copy link
Author

Thank you @Zaperex!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/enhancement New feature or request status/triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants