Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rotate leaves a black line on edge of image #104

Closed
etherbob opened this issue Jun 17, 2022 · 2 comments · Fixed by #118
Closed

rotate leaves a black line on edge of image #104

etherbob opened this issue Jun 17, 2022 · 2 comments · Fixed by #118

Comments

@etherbob
Copy link
Contributor

Seeing black lines on the edge of non-square images when rotating them.

Seeing this when rotating by multiples of 90 degrees using Image-processing via ActiveStorage::Variant against homebrew-installed vips: stable 8.12.2 (bottled)

Haven't dug too deeply but apparently this was an unavoidable issue in earlier versions of vips and the nodejs wrapper sharp. Trying to figure out now if I just need to pass some extra options, but also wondered if it would make sense to change how ImageProcessing::Vips called rotate to avoid this.
@etherbob etherbob mentioned this issue Jun 20, 2022
Open
@etherbob
Copy link
Contributor Author

Per libvips/ruby-vips#338 it looks like I should've been using rot90 and friends for this purpose. I asked there, but also wonder if image processing might be the right place to short-circuit rotate to the appropriate rot* command when degrees are 90, 180, 270, -90, -180, -270?

@etherbob etherbob mentioned this issue Dec 1, 2023
Merged
@etherbob
Copy link
Contributor Author

@janko not trying to rush, but any chance you'd be able to look at my PR that attempts to resolve this issue?

@janko janko closed this as completed in #118 Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use rot command where possible etherbob/image_processing
1 participant
@etherbob