Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move access grant generation to a background job #63

Open
elf-pavlik opened this issue Oct 22, 2022 · 0 comments
Open

move access grant generation to a background job #63

elf-pavlik opened this issue Oct 22, 2022 · 0 comments
Assignees
Labels
service Node service to run authorization agents

Comments

@elf-pavlik
Copy link
Collaborator

Currently, the service used by api handler does it. It should only record the Access Authorization and create a background job for generating an Access Grant.

We should consider possible racing conditions caused by it. If we redirect back to the app before generating an access grant the app can check its registration and find no access grant.. Applications should subscribe to notifications from their application registration anyways and in that case, they will get notified as soon as an access grant gets generated. We might wait with this change until Solid Notifications get decent implementations.

@elf-pavlik elf-pavlik self-assigned this Jun 6, 2023
@elf-pavlik elf-pavlik transferred this issue from janeirodigital/sai-impl-service Jun 6, 2023
@elf-pavlik elf-pavlik added authorization-agent Top level module for authorization agents service Node service to run authorization agents and removed authorization-agent Top level module for authorization agents labels Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service Node service to run authorization agents
Projects
None yet
Development

No branches or pull requests

1 participant