Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove package-lock.json and/or yarn.lock from Git ignored files #30

Open
angelaraya opened this issue Jan 28, 2022 · 2 comments
Open
Assignees
Labels
conventions General conventions to assist development

Comments

@angelaraya
Copy link
Contributor

It is highly recommended you commit the generated package lock to source control: this will allow anyone else on your team, your deployments, your CI/continuous integration, and anyone else who runs npm install in your package source to get the exact same dependency tree that you were developing on.
Source

Right now there is no lock file being committed with the repository so the builds can vary from one to another. Another option is to pin the dependencies to an specific version instead of a range.

@angelaraya angelaraya self-assigned this Oct 6, 2022
@angelaraya
Copy link
Contributor Author

@elf-pavlik I've run into several problems because I keep using npm instead of yarn which seems to work better along lerna. I I can build and commit the yarn.lock file and update the readme to mention that yarn is a requirement.

@elf-pavlik
Copy link
Collaborator

SGTM, if any issue comes up with requiring yarn we can always look at a different setup.

@elf-pavlik elf-pavlik added the conventions General conventions to assist development label Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conventions General conventions to assist development
Projects
Status: In Progress
Development

No branches or pull requests

2 participants