Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract code from shared/app.ts and put into individual modes #30

Open
mickmister opened this issue Dec 27, 2023 · 0 comments
Open

Extract code from shared/app.ts and put into individual modes #30

mickmister opened this issue Dec 27, 2023 · 0 comments

Comments

@mickmister
Copy link
Member

mickmister commented Dec 27, 2023

There's a lot of code in app.ts that has to do with things like adhocProgressionMode and wled stuff. These things should be better de-centralized.

Wled stuff can all go into the wled service, then expose the intended actions on the app object if necessary. app.wledActions.changePreset. That seems fine to me. Then WledService defines what those actions are.

https://github.com/jamtools/jamtools/pull/29#discussion_r1436813545

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

1 participant