From fc2bf0bdc85ccac7956ab5f341d7b328f1987242 Mon Sep 17 00:00:00 2001
From: Jamie Brynes <jamiebrynes7@gmail.com>
Date: Fri, 2 Feb 2024 22:43:08 +0000
Subject: [PATCH] Fix opening tasks in app on mobile devices (#281)

---
 CHANGELOG.md       |  4 ++++
 src/contextMenu.ts | 42 +++++++++++++++++-------------------------
 2 files changed, 21 insertions(+), 25 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 8f39e08..409bc6d 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -31,6 +31,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Changed all icons to be part of the Lucide set to align with Obsidian.
 - The `title` part of the query is now optional.
 
+### 🐛 Bug Fixes
+
+- Opening tasks via the context menu should now work properly on mobile devices.
+
 ## [1.11.1] - 2023-04-09
 
 ### 🐛 Bug Fixes
diff --git a/src/contextMenu.ts b/src/contextMenu.ts
index ce3449c..550d971 100644
--- a/src/contextMenu.ts
+++ b/src/contextMenu.ts
@@ -40,28 +40,20 @@ export function showTaskContext(
     .showAtPosition(position);
 }
 
-const openExternal: (url: string) => Promise<void> = async (url: string) => {
-  try {
-    await getElectronOpenExternal()(url);
-  } catch {
-    new Notice("Failed to open in external application.");
-  }
-};
-
-type OpenExternal = (url: string) => Promise<void>;
-
-let electronOpenExternal: OpenExternal | undefined;
-
-function getElectronOpenExternal(): OpenExternal {
-  if (electronOpenExternal) {
-    return electronOpenExternal;
-  }
-
-  try {
-    electronOpenExternal = require("electron").shell.openExternal;
-  } catch (e) {
-    electronOpenExternal = (url) => Promise.resolve();
-  }
-
-  return electronOpenExternal;
-}
+// A bit hacky, but in order to simulate clicking a link
+// we create a unparented DOM element, dispatch an event,
+// then remove the link. Using electron's openExternal doesn't
+// work on mobile unfortunately.
+function openExternal(url: string): void {
+  const link = document.createElement("a");
+  link.href = url;
+
+  const clickEvent = new MouseEvent("click", {
+    bubbles: true,
+    cancelable: true,
+    view: window
+  });
+
+  link.dispatchEvent(clickEvent);
+  link.remove();
+}
\ No newline at end of file