Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put COBS dependency and functions behind a feature flag #200

Open
bplaat opened this issue Jan 17, 2025 · 2 comments
Open

Put COBS dependency and functions behind a feature flag #200

bplaat opened this issue Jan 17, 2025 · 2 comments
Labels
postcard-2.0 Tracking issues for an eventual 2.0 version of the postcard wire format (not currently planned)

Comments

@bplaat
Copy link

bplaat commented Jan 17, 2025

Maybe I'm wrong, but I saw with a brief look at the code that the code that provided COBS encoding/decoding can be made optional. I use postcard in my project purely as a bin serialize data store, so it would be nice if *_cobs and the cobs dependency could be put behind a (default) feature flag.

@jamesmunns if you think this is a good idea I will make it and create a pr, but I wanted to hear your opinion first :^)

@jamesmunns
Copy link
Owner

I'm fairly certain this would be a breaking change. If a user has default features enabled today, and uses cobs, and we make it an optional feature, then postcard will break.

@jamesmunns jamesmunns added the postcard-2.0 Tracking issues for an eventual 2.0 version of the postcard wire format (not currently planned) label Jan 17, 2025
@bplaat
Copy link
Author

bplaat commented Jan 17, 2025

Yes that's true, I had in my head that postcard was at a 0.x.x version, so breaking things was less dangerous, but it's not. Putting this future request for a 2.0 release is a great idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
postcard-2.0 Tracking issues for an eventual 2.0 version of the postcard wire format (not currently planned)
Projects
None yet
Development

No branches or pull requests

2 participants