-
-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add global from to Mailing docs #320
Comments
Cool! Would love the help. You can have a look at this file (the docs for the mailer): https://github.com/jamesmh/coravel/blob/master/DocsV2/docs/Mailing/README.md |
Sounds good! One quick question, I noticed that calling I know this is a little more involved than just the docs so if it's something you're interested in I'll get this into a separate issue and PR. |
Ya I think that makes sense to override the global from if you call |
This is fixed - thanks! |
Describe the solution you'd like
The documentation (great as it is) is missing details about the usage of
globalFrom
in service registration which would've sped up development for my use case. After digging into the source code I have a good handle on it. If you'd like I'd be happy to take a stab at a PR!The text was updated successfully, but these errors were encountered: