Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add global from to Mailing docs #320

Closed
lwestfall opened this issue Dec 14, 2022 · 4 comments
Closed

Add global from to Mailing docs #320

lwestfall opened this issue Dec 14, 2022 · 4 comments

Comments

@lwestfall
Copy link

Describe the solution you'd like
The documentation (great as it is) is missing details about the usage of globalFrom in service registration which would've sped up development for my use case. After digging into the source code I have a good handle on it. If you'd like I'd be happy to take a stab at a PR!

@jamesmh
Copy link
Owner

jamesmh commented Dec 14, 2022

Cool! Would love the help. You can have a look at this file (the docs for the mailer):

https://github.com/jamesmh/coravel/blob/master/DocsV2/docs/Mailing/README.md

@lwestfall
Copy link
Author

Sounds good!

One quick question, I noticed that calling .From("[email protected]") in Build() doesn't seem to override the globalFrom address. Would it be better if it did? In my mind it seems like globalFrom should sort of be treated as a "default" from address, which can be overridden when building (maybe someone wants to conditionally override the from address, or certain Mailable implementations should have a different From address, etc).

I know this is a little more involved than just the docs so if it's something you're interested in I'll get this into a separate issue and PR.

@jamesmh
Copy link
Owner

jamesmh commented Dec 15, 2022

Ya I think that makes sense to override the global from if you call From() 👍

@jamesmh
Copy link
Owner

jamesmh commented Sep 20, 2024

This is fixed - thanks!

@jamesmh jamesmh closed this as completed Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants