Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build a Streaming Aggregation Processor For Service Map #6153

Open
mahadzaryab1 opened this issue Nov 2, 2024 · 5 comments
Open

Build a Streaming Aggregation Processor For Service Map #6153

mahadzaryab1 opened this issue Nov 2, 2024 · 5 comments
Labels
area/otel changelog:new-feature Change that should be called out as new feature in CHANGELOG enhancement

Comments

@mahadzaryab1
Copy link
Collaborator

mahadzaryab1 commented Nov 2, 2024

Implement a processor in the OTEL pipeline that takes as input a stream of traces and constructs a dependency graph between services.

@dosubot dosubot bot added area/otel changelog:new-feature Change that should be called out as new feature in CHANGELOG labels Nov 2, 2024
@mahadzaryab1
Copy link
Collaborator Author

@yurishkuro in this first step, do we just want to compute the dependencies in an apache beam pipeline?

@yurishkuro
Copy link
Member

Yes but also implement that as an OTEL Processor. You can probably copy the existing processor from contrib (mentioned in the comments above) as a baseline.

@mahadzaryab1
Copy link
Collaborator Author

@mahadzaryab1
Copy link
Collaborator Author

@yurishkuro Another question - looks like OTEL has a groupbytraceprocessor. Is there any way we could leverage this or do we need to reuse this logic inside the processor that we write?

@yurishkuro
Copy link
Member

No, I was referring to ServiceGraphConnector

groupbytraceprocessor is not needed for memory/badger, but may be needed for distributed storage. It somewhat depends on how Apache Beam implements the streams - if we have to shard spans by trace ID manually then something from OTEL will be needed (it's the same problem as with tail sampling processor, which needs full traces in one collector).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/otel changelog:new-feature Change that should be called out as new feature in CHANGELOG enhancement
Projects
None yet
Development

No branches or pull requests

2 participants