Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jaeger-v2] Do away with storage.ArchiveFactory #5230

Open
yurishkuro opened this issue Feb 25, 2024 · 2 comments · May be fixed by #5279
Open

[jaeger-v2] Do away with storage.ArchiveFactory #5230

yurishkuro opened this issue Feb 25, 2024 · 2 comments · May be fixed by #5279
Labels
v2

Comments

@yurishkuro
Copy link
Member

Per comment https://github.com/jaegertracing/jaeger/pull/5152/files#r1501916983

We need to get rid of storage.ArchiveFactory interface because it is conceptually meaningless - archive storage is just a storage that implements SpanStorage interface. It should be the same thing with Factory, just have a storage.Factory that in context can be interpreted as primary or archive. We unnecessarily bundle these two.
@yurishkuro yurishkuro mentioned this issue Feb 25, 2024
Merged
4 tasks
@h4shk4t
Copy link
Contributor

h4shk4t commented Feb 26, 2024

I would like to work on this.

@pavolloffay pavolloffay added the v2 label Mar 13, 2024
@akagami-harsh akagami-harsh linked a pull request Mar 16, 2024 that will close this issue
Draft
4 tasks
@Wise-Wizard
Copy link
Contributor

Can I work on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
v2
Projects
Jaeger V2
Status: Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove archive storage factory akagami-harsh/jaeger
4 participants
@yurishkuro @pavolloffay @h4shk4t @Wise-Wizard