Skip to content
This repository has been archived by the owner on May 18, 2020. It is now read-only.

Reorganize templates #54

Open
jpkrohling opened this issue Oct 25, 2017 · 3 comments
Open

Reorganize templates #54

jpkrohling opened this issue Oct 25, 2017 · 3 comments

Comments

@jpkrohling
Copy link
Collaborator

jpkrohling commented Oct 25, 2017

The current organization of the templates has become confusing (production vs. production-elasticsearch, for instance).

A recommendation is the following:

.
├── development (currently, it's the all-in-one)
│   └── development.yaml
└── production
    ├── cassandra.yaml
    ├── elasticsearch.yaml
    └── jaeger.yaml

Of course, the tests have to be adjusted for this.

@jpkrohling
Copy link
Collaborator Author

@pavolloffay what do you think?

@pavolloffay
Copy link
Member

Proposed structure looks good. The names should contain jaeger prefix eg. jaeger-production.yml.

Currently, It's also odd that we add -template suffix. It should be removed.

@pavolloffay
Copy link
Member

This might be tricky task, it requires some arquillian skills to use different arquillian.xml in the same maven module. This will also affect travis build as we are using travis stages per storage.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants